search

Qucs / qucs

Qucs Project official mirror
http://qucs.sourceforge.net/
GNU General Public License v2.0
1.16k stars 213 forks source link

do not use else, because when all documents are closed, a new one sho… #1034

Closed Murmele closed 3 years ago

Murmele commented 3 years ago

A new document should be created also when all files are closed successfully

felix-salfelder commented 3 years ago

On Fri, Jan 08, 2021 at 08:04:46AM -0800, Murmele wrote:

A new document should be created also when all files are closed successfully You can view, comment on, or merge this pull request online at:

thanks. can you say why it should be created? is this opinion/taste or is it because 0.0.20 does it?

what is sensible? how do other programs do it? e.g.

firefox: close all tabs -> also closes main app gimp: close all images -> nothing else happens

which one makes more sense? Why do we have to care at this stage?

Murmele commented 3 years ago

It is when a project will be opened. The problem is, if the file gets not created and you drop a component a segmentation fault occurs.

felix-salfelder commented 3 years ago

On Fri, Jan 08, 2021 at 10:16:37AM -0800, Murmele wrote:

It is when a project will be opened. The problem is, if the file gets not created and you drop a component a segmentation fault occurs.

drop as in drag&drop from the left menu? does this work for you at all? I think just selecting a symbol and clicking somewhere on the scene is working much better (how does 0.0.20 do it?).

do we want/need drag&drop? some code needs debugging or removal, either way.

Murmele commented 3 years ago

Both is working for me. Hmm for me also selecting is also fine. But I found it just in a second step. I will show a video

Murmele commented 3 years ago

The ground was dragged, the opamp was selected without dragging https://user-images.githubusercontent.com/10099533/104089217-57a0c900-526d-11eb-8b02-c312e7270979.mp4