search

Qucs / qucs

Qucs Project official mirror
http://qucs.sourceforge.net/
GNU General Public License v2.0
1.16k stars 213 forks source link

Fixes to allow compilation on Windows using MSYS2 MINGW64 toolchain #1092

Closed EmilKleijn closed 1 month ago

EmilKleijn commented 1 month ago

This patch fixes the following issues:

felix-salfelder commented 1 month ago

On Tue, Sep 24, 2024 at 12:01:09PM -0700, EmilKleijn wrote:

This patch fixes the following issues:

  • git raising an error on 1u not being an integer during bootstrap / autoconf

Interesting. Don't know where the u came from. Works without for me.

  • Name clash of lst2 and lst3 with defines in dlgs.h
  • Name clash of Arc with function definition in wingdi.h
  • toAscii deprecation, replaced with toLatin1

I agree, except for the "using namespace" in header files. It makes code even harder to read. Please consider removing it.

I don't think it's as much of a problem in .cpp files, but even there, I would prefer to pick one at a time.

using qucs::Arc; [..]

Not everything qucs has should show up everywhere. Fully qualified names are also an option.

  • Missing QtScript in configure.ac caused compilation errors

You are right. I thought it's no longer needed with Qt6, but theres more work to do.

Thanks.

EmilKleijn commented 1 month ago

I'll remove the using namespace qucs from the header files and use the fully qualified name everywhere. It will take some time to refactor though, as there are many files to change.

felix-salfelder commented 1 month ago

On Wed, Sep 25, 2024 at 04:40:36AM -0700, EmilKleijn wrote:

I'll remove the using namespace qucs from the header files and use the fully qualified name everywhere. It will take some time to refactor though, as there are many files to change.

Thanks!