search

Qucs / qucs

Qucs Project official mirror
http://qucs.sourceforge.net/
GNU General Public License v2.0
1.15k stars 213 forks source link

`define` inside `qucs` namespace makes no sense #178

Closed guitorri closed 9 years ago

guitorri commented 9 years ago

This does not make much sense: https://github.com/Qucs/qucs/blob/master/qucs-core/src/consts.h#L37-L48

A #define is handled by the preprocessor and end up having global scope.

We should replace the #define by typed const instead.

The fix looks easy, but it has implication on the Verilog models and ADMS generator.

As a mater of fact we had to work around the collision of T0 from qucs with a T0 variable on the BSIM6 model.

guitorri commented 9 years ago

Fix merged in 1a856890df45b8dd0d547f7cdeffb20d9bfaf352