search

Qucs / qucs

Qucs Project official mirror
http://qucs.sourceforge.net/
GNU General Public License v2.0
1.15k stars 213 forks source link

Stale Include? #270

Closed nvdl closed 9 years ago

nvdl commented 9 years ago

In "searchdialog.cpp"

include "ui_searchdialog.h"

Is it a stale include?

guitorri commented 9 years ago

This should come from https://github.com/Qucs/qucs/blob/master/qucs/qucs/dialogs/searchdialog.ui This is the only dialog created in this format. After this was merged we decided to keep the dialogs coded by hand instead of investing time on converting them to the UI designer.

nvdl commented 9 years ago

Was getting compilation error.

"ui_searchdialog.h" was empty on my side. Do not know how it ended up like that.

Fixed by copying the file from master branch.

Strange enough:

git checkout -b master-tracker git reset --hard upstream/master -- git push origin master-tracker

did not give me the exact clone of master branch i.e "ui_searchdialog.h" was an empty file. Is this file missing tracking information or (more probably) am I cloning the not-so-correct way?

Looks like Makefile generates this from "ui" file; "autogen" script?

I agree, they should be hand-coded as almost all of them are simple in design. Personally, I do not like the way buttons stretch when the form width is increased though. They tend to stretch beyond infinity!