qucs crash when editing component properties

Qucs / qucs

Qucs Project official mirror

http://qucs.sourceforge.net/

GNU General Public License v2.0

1.15k stars 213 forks source link

Closed kraus1049 closed 8 years ago

kraus1049 commented 8 years ago

1. Put "dc Voltage source"
2. Right click and choose "Edit Properties"
3. Press Enter key twice

qucs will fail into segmentation fault after step 3.

$ qucs --version
Qucs 0.0.19 (9d924ca)

＄ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04 LTS"

$ arch
x86_64

andresmmera commented 8 years ago

Hello,

I've tracked down the seg fault. It seems that this line should be:

if ( row < prop->rowCount()-1) {

row is an integer ranging from 0 to prop->rowCount()-1, so Qucs tries to access a non-existing element...

prop->setCurrentItem(prop->item(row+1,0));

row+1 > prop->rowCount()-1 => here's the seg fault

Should I open a PR with the patch?

in3otd commented 8 years ago

Should I open a PR with the patch?

why shouldn't you? :grin:

andresmmera commented 8 years ago

just checking :-)

in3otd commented 8 years ago

Fixed in #514.

Thanks @kraus1049 for reporting the issue!