Qucs / qucs

Qucs Project official mirror

http://qucs.sourceforge.net/

GNU General Public License v2.0

1.15k stars 213 forks source link

Error messages in Qucslib #591

Closed ra3xdh closed 7 years ago

ra3xdh commented 7 years ago

Every user library with Default symbol defined gives an error message when trying to open in library manager. Steps to reproduce:

Move NMOSFETs.lib library into $HOME/.qucs/user_lib
Select this library at ComboBox. Use user version of library.
The following error message will be shown:

It coul d be seen from the error text that library file name is not determined properly. I think, it appears after #556

felix-salfelder commented 7 years ago

FTR: i have rebased the non-hotfix approach to #556. see #592. (help definitely appreciated).

ra3xdh commented 7 years ago

592 is not a good solution to fix this particular issue, because it is a deep refactoring proposal. I don't recommend start refactoring right at release time. Let's discuss your refactoring concepts after 0.0.19 will be released.

felix-salfelder commented 7 years ago

yes, the non-hotfix approach is currently targeting devel, only with some help from others that might change.

and no, there's no "deep refactoring" involved just for this, i intentionally postponed that. read the comments/commits and disussion.

ra3xdh commented 7 years ago

There exists another issue in Library Manager. It always show an an empty symbol for devices (not subcircuits) libraries. Try to select Transistor or Diode library and you will see the following. Component symbol will be empty. I think it appears after #580 liberror1

guitorri commented 7 years ago

Seems fixed with #594