Closed in3otd closed 7 years ago
Yes, I know about this problem. I always use clipboard editing to allow copy-pasting between versions. This issue should not concern simple users, because they usually uses only single Qucs version. But it makes development and debugging a bit more difficult.
perhaps, as long as loading old schematics is not fully tested, we should warn "loading old schematic, please be careful", instead? return false
seems to be entirely pointless to me.
yep, I was sure this was already known, but wanted to have a remainder to fix it :grin:
Currently we load old schematics without any user warning, I think we should have the same behavior (emit warning or not) when pasting. When 0.0.19
will be out, all existing users' (vs. developers) schematics will become old.
There also something about loading future versions: https://github.com/Qucs/qucs/blob/release-0.0.19/qucs/qucs/dialogs/qucssettingsdialog.cpp#L134
I was trying to understand the logic of the current code about loading from future versions: at present having it checked or unchecked makes practically no difference...
.sch
files in the tree view, also from future versions, regardless of the related setting status (see the code here; n
is negative for future versions but this case is not actually treated differently)
This is different from the behaviour of previous versions: in 0.0.17
the files from future versions were not shown (see the code here)So, what I propose is to modify the current behavior as:
seems reasonable ?
(Edit: moved a sentence which ended up at the end to its proper place)
Fixed in #607
In the GUI we can open schematics from previous versions but when trying to paste a schematic from a previous version a "Wrong document version" error pops up.
This comes from here where the pasted schematic version needs to be the same as the current Qucs version.
To easily reproduce:
0.0.18
(could maybe reuse the first commit of #340 to ease checking)