search

Qucs / qucs

Qucs Project official mirror
http://qucs.sourceforge.net/
GNU General Public License v2.0
1.16k stars 213 forks source link

Optimization is still broken #861

Closed in3otd closed 5 years ago

in3otd commented 6 years ago

the fix in #800 is not enough; the optimization runs but the final results are not updated in Qucs due to a missing last step in the "general optimization" mode of ASCO (w.r.t. the "Qucs mode")

guitorri commented 6 years ago

Any progress on this one?

in3otd commented 6 years ago

yes, I've tested #865 on Linux and Windows and it works fine here. Still I'd like to do more testing to avoid having to fix it a third time :grimacing:

in3otd commented 5 years ago

fixed by #865

michal777 commented 5 years ago

Optimization doesn't work for me. Linux mint 19, fresh build. Looks like the simulation is done but results are not available. No problems in qucs-s. Should I open new bug report?

in3otd commented 5 years ago

Does the optimization appear to progress normally? In the Simulation Messages window you should see values for Best-so-far cost funct. value and cost-variance which are not too big. If they stay at e.g. 1e31 something is wrong with the optimization and in these cases I've seen that when it stops due to the maximum number of iterations reached there are no results available.

Also, just to be sure, did you patch ASCO as per #865? ~Anyway, if you have qucs in the path this may not be needed.~ Edit: patching ASCO is needed, see below. "fresh build" means you are on which commit? Can you share the failing example?

michal777 commented 5 years ago

I compared outputs (F5 key) from qucs and qucs-s - they are identical but the correct results are only available in qucs-s Now I've got ASCO 0.4.10 downloaded from the http://asco.sourceforge.net/ and qucs cloned today from this repo (Latest commit d25203a 3 days ago). I assumed the #865 is merged in this repo so I needn't care. Do I miss something? The example is simple voltage divider. tmp.sch.txt qucs_optim_log.txt

in3otd commented 5 years ago

ok, I can reproduce it also here, if I do not patch ASCO. Due to the way now the ASCO optimizer is called you do need the patch to ASCO 0.4.10 which was added in #865.

guitorri commented 5 years ago

@in3otd did you send the patch upstream?

in3otd commented 5 years ago

no, I didn't. But the patched ASCO should still work with the pre-#730 Qucs (and likely with Qucs-S) - I did not actually check yet - so it may make sense to have it included upstream.

dom11990 commented 4 years ago

I'm not able to get this to work... maybe i am doing something wrong but when I try to apply the patch?

patch --dry-run -p1 < ASCO-Qucs_simulator_name.patch 
checking file asco-test.c
Hunk #1 FAILED at 29.
Hunk #2 FAILED at 179.
2 out of 2 hunks FAILED
checking file asco.c
checking file errfunc.c