search

Qucs / qucs

Qucs Project official mirror
http://qucs.sourceforge.net/
GNU General Public License v2.0
1.16k stars 213 forks source link

Refix optimization #865

Closed in3otd closed 5 years ago

in3otd commented 6 years ago

Patched ASCO to allow passing the full path of simulator required by Qucs.

Removed the stuff about the ASCO "general" mode since it does not contain a post-simulation step to be executed, which we need to update the Qucs result file. Adding a pre- and post-execution steps to ASCO would have been more general but I just wanted to fix the usage with Qucs here.

Works on Linux here, I'll test on Windows later.

in3otd commented 6 years ago

um, clang spams the build log on Travis repeating these lines

clang-5.0: warning: argument unused during compilation: '-I .' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-I ../../../../qucs-core/src/interface' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-I ../..' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-I ../../../../qucs-core/src' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-I ../../../../qucs-core/src/math' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-I ../../../../qucs-core/src/components' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-I ../../src/components' [-Wunused-command-line-argument]

which has this as an unfortunate side effect 

The job exceeded the maximum log length, and has been terminated.
in3otd commented 6 years ago

Works on Linux here, I'll test on Windows later.

I've done more testing on both Linux and Windows and it seems to work as expected with every circuit I tried.

felix-salfelder commented 5 years ago

rebase?

in3otd commented 5 years ago

ok, likely tomorrow. Being a bugfix, should this be also in release (or it's already there?)

felix-salfelder commented 5 years ago

On Mon, Dec 10, 2018 at 12:26:53PM -0800, in3otd wrote:

ok, likely tomorrow. Being a bugfix, should this be also in release (or it's already there?)

no rush. i was just thinking the CI fail was due to earlier generic build issues, and not due to problems with your patch.

release.. i think everything made it into develop. i wouldn't object to call it 0.0.20 any time now.

thanks

in3otd commented 5 years ago

as mentioned also in #884, something went bad with the OS X build, we now get errors like parse_citi.ypp:52.14-20: syntax error, unexpected string, expecting = It seems there we use bison 2.3.0 while elsewhere we have bison 3.0.2. I saw that a newest bison is already installed during the OS X build but there are some warnings about needing to set paths/compiler flags. @guitorri can you try to take a look at this?

felix-salfelder commented 5 years ago

@in3otd please rebase on top of #888, or i will do it (with your permission).

.. this is the last one holding back 0.0.20-rc1 (as it seems).

in3otd commented 5 years ago

um, Travis is still not happy. I can take a closer look later this evening or feel free to work on this in the meantime if you wish.

in3otd commented 5 years ago

Travis cmake build had strange errors, restarted two times and now it's passing.

felix-salfelder commented 5 years ago

On Thu, Jan 03, 2019 at 10:06:53AM -0800, in3otd wrote:

Travis cmake build had strange errors, restarted two times and now it's passing.

thanks.

will restart develop accordingly, as needed.

felix-salfelder commented 5 years ago

travis/osx was happy with on 3e15e312c1a90a. now it fails on develop (0b1453bedac195a) after the merge... "No output has been received in the last 10m0s".

any clue? either way, i think it is about time for a qucs-0.0.20-rc1 tag...

in3otd commented 5 years ago

very strange, it should just terminate at that point instead of hanging there. I tried to restart it but still behaves the same. I've sent a message to the Travis support about this.