Qucs / qucs

Qucs Project official mirror
http://qucs.sourceforge.net/
GNU General Public License v2.0
1.16k stars 213 forks source link

Renaming qucs-core to qucsator break Verilog-A makefile #901

Closed guitorri closed 5 years ago

guitorri commented 5 years ago

This https://github.com/Qucs/qucs/blob/master/qucs-core/configure.ac#L9

Breaks these https://github.com/Qucs/qucs/blob/master/qucs-core/src/components/verilog/va2cpp.makefile#L17 https://github.com/Qucs/qucs/blob/master/qucs-core/src/components/verilog/cpp2lib.makefile#L25

guitorri commented 5 years ago

I will create a branch hotfix-0.0.20 from master to merge the fix against.

felix-salfelder commented 5 years ago

On Tue, Jan 22, 2019 at 01:26:11PM -0800, Guilherme Brondani Torri wrote:

https://github.com/Qucs/qucs/blob/master/qucs-core/configure.ac#L9

looks right to me.

https://github.com/Qucs/qucs/blob/master/qucs-core/src/components/verilog/va2cpp.makefile#L17

use @pkgincludedir@, and substitute in configure.

and possibly set ADMSXML = admsXml