Qucs / qucs

Qucs Project official mirror
http://qucs.sourceforge.net/
GNU General Public License v2.0
1.16k stars 213 forks source link

Fix wrong calculation of power probes #904

Closed Rmano closed 5 years ago

Rmano commented 5 years ago

The power probes implicitely had one of the voltage terminals connected to ground.

Rmano commented 5 years ago

This should fix #902 --- Sorry for the mess, I am a bit new to git and github

guitorri commented 5 years ago

Can you squash your commits?

Rmano commented 5 years ago

Ah... the only way I know to do it is to create another branch and do an interactive cherry-pick, and then close this and open another PR. Is there a better way? Otherwise I'll do it.

in3otd commented 5 years ago

you can just squash them in the same branch and then force-push to update the PR. There's a small git guide here, with some instructions about squashing commits.

Rmano commented 5 years ago

I think I did it! Thanks for the hint.

guitorri commented 5 years ago

Thank you.