Qucs / qucs

Qucs Project official mirror
http://qucs.sourceforge.net/
GNU General Public License v2.0
1.16k stars 213 forks source link

Fix S11 equation in the attenuator block #926

Closed andresmmera closed 5 years ago

andresmmera commented 5 years ago

As pointed out by @in3otd [1], there was a bug in the S11 equation of the attenuator component. It didn't match the docs. See [2] Eq. 9.76. This caused that the attenuator didn't work as expected if Z0 != 50Ohm

I think this fix should be included in the new release, so I targeted this to hotfix-0.0.20.

Before: Selection_010

After: Selection_011

https://gist.github.com/andresmmera/a4dacd0f3a698b7c75dcac15e6296b03

[1] https://sourceforge.net/p/qucs/mailman/message/36663139/ [2] http://qucs.sourceforge.net/tech/node51.html