search

Qucs / qucs

Qucs Project official mirror
http://qucs.sourceforge.net/
GNU General Public License v2.0
1.16k stars 213 forks source link

qucs#956 command line enhancement #984

Closed oxmon-2500 closed 4 months ago

oxmon-2500 commented 4 years ago

Ticket qucs#956 Command line enhancement: It is now possible to specify a project and schematic files to open by command line. Usage: /home/gAz_/local/qucs/bin/qucs [-h|--help] [-v|--version] qucs -n -i FILENAME -o FILENAME qucs -p -i FILENAME -o FILENAME.[pdf|png|svg|eps] qucs [ projectPath] [ filePath1 [ filePath2 ... ] ] ]

-h, --help display this help and exit -v, --version display version information and exit ...

Examples: qucs ../qucs-test/testsuite/AC_bandpass_prj/ bandpass.sch opa227.sch qucs ~/proj/qucs-test/testsuite/DC_AC_gain_prj "*.sch"

guitorri commented 4 years ago

What is the issue you are addressing? Please describe what your are trying to achieve in the commit message.

I would rather not modify the QucsApp() constructor. If we have to pass all possible initial settings to the constructor it will be a mess. Can't you add another method to pass the lists and set the things you want?

oxmon-2500 commented 4 years ago

@guitorri Thank you for the rebase advice. It was working perfect now. As you have the best overview over the development, and knowledge what issues are of the most importance, so feel free to point out what next issue can be approached by me. To my person: I'm retired software developer (last years mostly java) and the electronics knowledge is rather from my interests and not from my profession. Nevertheless it would be a pleasure to add some contribution to this great project. Cheers from Baden bei Wien/Austria Szymon

guitorri commented 4 years ago

Hi Szymon,

I meant that the description of the changes should be recorded on the commit message itself, not only on the GitHub pull request description. Also, preferably mention the issue number on the body of the message not on the title. If one day we change away from GitHub these numbers will be meaningless. See also: https://github.com/Qucs/qucs/wiki/Contribution#rules-about-commits

Try git commit --amend and edit the commit message.

Your interest on the project is appreciated. I would suggest you to take a look on the milestones for the next release and try to address issues from there. See https://github.com/Qucs/qucs/milestone/4 This one has high priority: #830

Cheers, Guilherme