search

Qucs / qucs

Qucs Project official mirror
http://qucs.sourceforge.net/
GNU General Public License v2.0
1.16k stars 213 forks source link

Fix two build failures #989

Closed jirislaby closed 4 years ago

jirislaby commented 4 years ago

I see two link failures:

    ld: CMakeFiles/transcalc.dir/transline.cpp.o: in function `transline::setProperty(char const*, double)':
    qucs/qucs-transcalc/transline.cpp:76: undefined reference to `QucsTranscalc::setProperty(QString, double)'
    and so on...

and:

    ld: CMakeFiles/libqucsator.dir/module.cpp.o: in function `qucs::module::closeDynamicLibs()':
    qucs-core/src/module.cpp:555: undefined reference to `dlclose'
    ld: CMakeFiles/libqucsator.dir/module.cpp.o: in function `qucs::module::registerDynamicModules(char*, std::__cxx11::list<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >)':
    qucs-core/src/module.cpp:485: undefined reference to `dlopen'

Fix the two by these 2 commits.

guitorri commented 4 years ago

Hi, thanks for the PR, however qt5-6-merge-rc1 is already old and I don't see this issue anymore. I am about to push qt5-16 which has a ton of changes and in sync with latest develop.

jirislaby commented 4 years ago

I am about to push qt5-16

Perfect – when can we expect that to happen?