search

Qucs / qucsator

Circuit simulator of the Qucs project
http://qucs.sourceforge.net
GNU General Public License v2.0
23 stars 12 forks source link

Cmake package #22

Open Murmele opened 3 years ago

Murmele commented 3 years ago

CMake support for qucsator. Needed by qucs cmake

felix-salfelder commented 3 years ago

please squash into one commit and remove all whitespace changes. I think this should be rebased to the qucsator:develop branch (updated).

Then, maybe ask Guilherme to have a look. Iirc, he has implemented this.

Murmele commented 3 years ago

I think it is not good to squash the history, because then it is gone. And in the FAQ.md I sumarized the problems I had and there solutions where I referenced by commit id.

felix-salfelder commented 3 years ago

On Mon, Dec 28, 2020 at 04:19:01AM -0800, Murmele wrote:

I think it is not good to squash the history, because then it is gone. And in the FAQ.md I sumarized the problems I had and there solutions where I referenced by commit id.

Add a "technical details" section to the README file, if there's anything important that you wish to put on the record.

felix-salfelder commented 3 years ago

Breaks make check. I suspect the changes to include statements. Please debug (revert?). Some of the changes look useful.