Quedale / OnvifDeviceManager

Onvif Device Manager for Linux
GNU General Public License v3.0
74 stars 17 forks source link

error: too many arguments to function ‘UdpDiscoverer__start’ #13

Closed sgofferj closed 6 months ago

sgofferj commented 8 months ago
┌─[sgofferj@enterprise][~/source/OnvifDeviceManager]
└──▪ make
  CC       src/app/onvifmgr-onvif_app.o
./src/app/onvif_app.c: In function ‘onvif_scan’:
./src/app/onvif_app.c:157:5: error: too many arguments to function ‘UdpDiscoverer__start’
  157 |     UdpDiscoverer__start(&discoverer, disco_in, AppSettingsDiscovery__get_repeat(app->settings->discovery), AppSettingsDiscovery__get_timeout(app->settings->discovery));
      |     ^~~~~~~~~~~~~~~~~~~~
In file included from ./src/app/onvif_app.c:10:
/home/sgofferj/source/OnvifDeviceManager/subprojects/OnvifDiscoveryLib/build/dist/include/discoverer.h:36:13: note: declared here
   36 | extern void UdpDiscoverer__start(struct UdpDiscoverer* self, void * user_data, int retry_count);
      |             ^~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:1261: src/app/onvifmgr-onvif_app.o] Error 1

On Ubuntu 22.04, latest git pulled

sgofferj commented 8 months ago

Build works after wiping the directory and re-pulling.

Quedale commented 6 months ago

I glad you figured out a workaround.

You received this error because I changed the method definition UdpDiscoverer__start on the dependent project OnvifDiscoveryLib.

Just for future reference, when pulling the latest changes, you can always run autogen.sh. It will perform an incremental run and fetch the latest changes from those dependent projects. The autogen script is relatively fast after a first successful run.

Cheers!

sgofferj commented 6 months ago

Great, thanks!