search

Queens-Hacks / qcumber-scraper

Scrapes SOLUS and generates structured data
3 stars 6 forks source link

Fix swapped attributes #28

Closed Graham42 closed 9 years ago

Graham42 commented 9 years ago

The regex parses something like 001-LEC (1234) which makes sense to be of the format {class_num}-{type} ({solus_id})

Unless I'm missing something?

The regex is at line 21

pR0Ps commented 9 years ago

This is definitely wrong, but the attributes may be swapped in more than one place (I remember something about this before).

Can you do a before/after test to verify that the old behaviour was wrong and the new is correct? If so, then we can just merge this. If this PR switches the attributes to be incorrect, some code somewhere else will need to be changed too.

pR0Ps commented 9 years ago

Actually, I just found this commit in the #23 PR: https://github.com/Queens-Hacks/qcumber-scraper/commit/d8433a8a1225188fcc741a2db8dad9d5cfd374c0 . No wonder the problem seemed familiar.

When #23 is merged this issue will be fixed so I'll just close this one.