QueerCodeOrg / queercodeberlin.github.io

The Jekyll website for all Queer Code groups.
https://queer-code.org
The Unlicense
6 stars 12 forks source link

recaptcha missing for slackin widget #27

Closed lucymhdavies closed 6 years ago

lucymhdavies commented 6 years ago

Something I didn't notice when I added the widget to the site...

It has reCAPTCHA working on the https://slackinvite-qcldn.herokuapp.com/ directly, but the widget version on queer-code.org isn't working.

Hopefully a missed config when I added it, and thus an easy fix. But might be a bug with slackin itself, so worth checking known issues: https://github.com/rauchg/slackin/issues

in the queer-code.org widget:

<div class="g-recaptcha" data-sitekey="undefined"></div>

on https://slackinvite-qcldn.herokuapp.com/

<div class="g-recaptcha" data-sitekey="6Lf-MikUAAAAAFPg9M5Q_au-hIdfVST8oLW9Cnmx">

So need to get that working. Could be someting missing, or could be a slackin issue

chromy commented 6 years ago

Pretty sure it's a slackin bug, seems like this line in the iframe code path: https://github.com/rauchg/slackin/blob/master/lib/index.js#L248 should pass gcaptcha_sitekey like this line does: https://github.com/rauchg/slackin/blob/master/lib/index.js#L97

chromy commented 6 years ago

I put together a fix which seems to work when I test it locally: https://github.com/chromy/slackin/commit/c12cc051fb2a3d77397148f565377daa75abec6a I'll send it as a pull request tomorrow.

lucymhdavies commented 6 years ago

Well spotted!

chromy commented 6 years ago

Okay sent https://github.com/rauchg/slackin/pull/353 :smiley: The last merged pull request was Aug 2nd though so it might be a while before it gets merged...

lucymhdavies commented 6 years ago

We could run off your fork for a while until that's merged, I guess.

Or, in the interim, use the svg widget.

<img src="https://slack.yourdomain.com/badge.svg">
jukecraft commented 6 years ago

@chromy I've deployed your master on heroku but I'm not sure it's working.

chromy commented 6 years ago

Hmm, yeah I think I was looking at the wrong page when I was testing. @franziskas could you try again with https://github.com/chromy/slackin, I updated my commit and hopefully got it right this time. 🤞

jukecraft commented 6 years ago

@chromy - the capture is there but unfortunately no button to register - reverting for now

screen shot 2017-11-24 at 07 22 15
lucymhdavies commented 6 years ago

Ah. That'll be a CSS issue, I imagine. The Register button is probably hidden beneath the bottom of the widget.

dirv commented 6 years ago

I’ve updated our Heroku instance to the latest Slackin. Got a warning about an outdated Stack on Heroku, I’ll raise another issue for that.