Queerbric / Inspecio

A Minecraft mod which adds more tooltip components to items.
https://modrinth.com/mod/inspecio
GNU Lesser General Public License v3.0
102 stars 25 forks source link

inspecio-1.3.0+1.18 with charm-1.18-4.0.0 causes SimpleJsonResourceReloadListener to no longer fire for other mods #74

Closed TelepathicGrunt closed 2 years ago

TelepathicGrunt commented 2 years ago

1.18-4.0.0 charm alongside inspecio-1.3.0+1.18 in a modpack is blowing up for some reason and causing my mod's SimpleJsonResourceReloadListener to not fire which is bad (my structure's spawners will not get the correct mobs anymore and my mod compat datapacks would break) https://github.com/TelepathicGrunt/RepurposedStructures-Fabric/blob/009611c796c46022d51cce9df7ec05d05cc3dd86/src/main/java/com/telepathicgrunt/repurposedstructures/misc/mobspawners/MobSpawnerManager.java#L34

When I removed charm only or inspecio, the modpack works and my json files gets parsed just fine. The log when they conflict: https://paste.ee/p/um8ki

I have RS logging in my test when SimpleJsonResourceReloadListener's apply is ran and parses my json which should show up like this: https://paste.ee/p/4xVzF Those lines are not present in the above log so the conflict is killing the resource loader somehow which is going to break a lot of mods.

I can't get more info than this. Sorry. But at the very least, here's a reproducible case: image

Report to Charm as well: https://github.com/svenhjol/Charm/issues/761

Seems related to these issue reports as well: https://github.com/Queerbric/Inspecio/issues/72 https://github.com/Queerbric/Inspecio/issues/73

TelepathicGrunt commented 2 years ago

I reproduced the issue with inspecio-1.3.1+1.18 as well.

LambdAurora commented 2 years ago

Inspecio 1.3.x is no longer supported. Only Quilt versions of the mods for 1.18.2+ are supported.