search

Quentin-M / etcd-cloud-operator

Deploying and managing production-grade etcd clusters on cloud providers: failure recovery, disaster recovery, backups and resizing.
Apache License 2.0
234 stars 42 forks source link

terraform/common.tf: Enforce string type for some boolean values #50

Closed yifan-gu closed 4 years ago

yifan-gu commented 4 years ago

This fixes a backward compatibility issue with 0.12 terraform where if not specified explicitly, the "true" is not considered as boolean.

Without the change, eco_enable_tls = "true" is not the same as eco_enable_tls = true, thus running the terraform apply with the new eco module will delete the tls certs.

Alternatively, we should change all the types to boolean, but that will cause some backward compatibility issue as mentioned above.

yifan-gu commented 4 years ago

Also added a commit to upgrade the extra module and the aws module output.tf cc @bernadinm