QuentinGruber / h1z1-server

Library used to emulate h1z1 game servers
https://h1emu.com
GNU General Public License v3.0
94 stars 53 forks source link

Search Containers before displaying proximity #2050

Closed JayyWayz closed 4 months ago

JayyWayz commented 5 months ago

Re-implements Avcio's change that made players need to search containers before items display in proximity.

Nikolassparrow commented 5 months ago

Wasn't a thing lol Refer to #1862

https://www.youtube.com/watch?v=aFpSNGow3QI (Timestamps: 18:22 | 18:51 | 21:33 | 23:30 | 25:09 | 57:06 - can show more proof if need be 👍 )

In https://github.com/QuentinGruber/h1z1-server/pull/1777, avcio optimized getProximityItems so users can't proximity containers through base shelters (essentially esp), and just general code clean-up. Wonderful change! But in the process made it so world lootable props (armoires, cabinets, fridges etc.) had to be searched through at least once before you could proximity them. In december 2016 this wasn't a thing however. You could proximity world lootable props no matter what, so this PR aims to remove that restriction WHILE keeping avcios wonderful change from before :D

Z2Doggo commented 5 months ago

@Nikolassparrow While your contributions to this project are most graciously appreciated by the community who wants this game back, you will mostly have to brush up on double checking your contributions to the project in the first place due to the amount of bugs you have produced for the game server, whether it's intentional or not, please start looking over your work, sincerely. - Doggo

P.S ~ We were also very tired of cleaning up your buggy messes, especially Avcio, warm regards, - Doggo.