search

Quenty / NevermoreEngine

ModuleScript loader with reusable and easy unified server-client modules for faster game development on Roblox
https://quenty.github.io/NevermoreEngine/
MIT License
421 stars 124 forks source link

feat: Add RxCharacterUtils #262

Closed OttoHatt closed 2 years ago

OttoHatt commented 2 years ago

I didn't like doing Humanoid.Health > 0 every frame, so I made some small utilities for it. Sorry for not doing a changelog! Also will the package dependencies will need updating too??

Quenty commented 2 years ago

Looks good overall, I'm ok with merging as is, but left a few comments just in case you wanted to address them.

Quenty commented 2 years ago

No changelog necessary, it is auto-generated from commit. Same with dependency updates. This looks good.

OttoHatt commented 2 years ago

Added your improvements! This looks like it'll have some overlap with HumanoidTracker, but I don't think it's worth moving it to Rx?

OttoHatt commented 2 years ago

All good now, let me know if there’s anything else to change before merging.

github-actions[bot] commented 2 years ago

:rocket: PR was released in @quenty/characterutils@5.1.0, @quenty/cmdrservice@5.2.0, @quenty/coreguienabler@5.1.0, @quenty/deathreport@1.2.0, @quenty/equippedtracker@5.2.0, @quenty/gameconfig@3.2.0, @quenty/gameproductservice@3.2.0, @quenty/humanoidspeed@3.2.0, @quenty/idleservice@5.2.0, @quenty/ik@7.2.0, @quenty/parttouchingcalculator@6.2.0, @quenty/ragdoll@7.2.0, @quenty/softshutdown@1.2.0, @quenty/spawning@2.2.0 :rocket: