Quenty / NevermoreEngine

ModuleScript loader with reusable and easy unified server-client modules for faster game development on Roblox
https://quenty.github.io/NevermoreEngine/
MIT License
421 stars 124 forks source link

Optimise + document Table library #264

Closed OttoHatt closed 1 year ago

OttoHatt commented 2 years ago

Updated some of the table util functions to use the newer table. methods. Hopefully they'll be faster!(?). Also changed some doc phrasing.

I've done my best to test, but I know changes to a module like this can incur a lot of hard-to-find and obscure bugs (likely to do with mix/matching dictionary-style and array-style tables). Consider testing thoroughly with older nevermore projects, or simply not merging????

OttoHatt commented 2 years ago

It may be a good idea to rename the .readonly methods; they provide the nice functionality in erroring on a nil index, but I think it's easy to assume it does the same as table.freeze (which errors on write but not on nil indexing).

Quenty commented 1 year ago

Closed in favor of #321