search

Quenty / NevermoreEngine

ModuleScript loader with reusable and easy unified server-client modules for faster game development on Roblox
https://quenty.github.io/NevermoreEngine/
MIT License
421 stars 124 forks source link

Update SoftShutdownServiceClient.lua to fix ScreenGui not disabled. #267

Closed anscg closed 2 years ago

anscg commented 2 years ago

👋Hi! This is my first time contributing to an Open Source project, I don't really know how to contribute on GitHub, so I will make mistakes.

This PR is to fix the problem of SoftShutdownService not disabling UIs that are created after _hideCoreGuiUI is called. Also, it fixes that the soft shutdown UI not being on top, since 1E10 on a ScreenGui DisplayOrder will be solved as -2147483648 (The value is too big, I don't know if 1E10 is meant to be there).

unknown ^The ScreenGui is created after _hideCoreGuiUI is called.

I've tested my own code before opening a pull request.

Quenty commented 2 years ago

Thank you! I fixed this in another commit before seeing this!

If you edit this and JUST do the 1e9 that would be neat.