Blend.Single changes - Githubissues

Quenty / NevermoreEngine

ModuleScript loader with reusable and easy unified server-client modules for faster game development on Roblox

https://quenty.github.io/NevermoreEngine/

MIT License

407 stars 125 forks source link

Open OttoHatt opened 1 year ago

OttoHatt commented 1 year ago

Allow returning nil from the observable. We know that it will never evaluate to anything interesting, so there's no point creating a brio (which are not free). (Should also probably skip creating a brio if the passed observable is complete and evaluates to nil, i.e. == Rx.EMPTY?).
Propagate state of passed observable. This has just become a slightly more efficient version of a switchMap + toBrio.
Returning from a subscription does nothing.

Quenty commented 1 year ago

Side note: Rx.EMPTY never completes I believe.

OttoHatt commented 1 year ago

If propagating failure is contentious, is it possible to merge just the first of these commits for now?