search

Quenty / NevermoreEngine

ModuleScript loader with reusable and easy unified server-client modules for faster game development on Roblox
https://quenty.github.io/NevermoreEngine/
MIT License
391 stars 124 forks source link

fix: Using integer keys in w/ Observe methods in ObservableMap #470

Closed OttoHatt closed 3 days ago

OttoHatt commented 2 months ago

The maid is given some cleanup w/ :GiveTask, so they get given keys 1 and 2 internally. The value brios are also put into this maid, so if you did map:Set(1, ...) you'd break everything observing the container.

Quenty commented 2 months ago

Let's make a new maid specifically for the keys instead of trying to fix the :GiveTask() call. That way future changes won't break anything.

We should also maybe add a method to Maid that allows you to get/set a task that could conflict with a name. For example. GiveTask as a key could be really bad.

We should consider adding maid:Set() or something for safety.

github-actions[bot] commented 3 days ago

:rocket: PR was released in @quenty/adorneeboundingbox@8.3.1, @quenty/gameconfig@12.7.1, @quenty/gameproductservice@14.7.1, @quenty/highlight@10.4.1, @quenty/inputkeymaputils@14.6.2, @quenty/observablecollection@12.3.1, @quenty/scoredactionservice@16.7.2, @quenty/settings-inputkeymap@10.8.2, @quenty/settings@11.6.1, @quenty/soundgroup@1.3.1 :rocket: