search

Querela / cql-python

CQL (Contextual Query Language) Parser in Python
0 stars 1 forks source link

you could add few type hints to the code files so that it would be easy to interpret the code in a much easier way. #3

Open vignesh1507 opened 1 month ago

vignesh1507 commented 1 month ago

This can be taken as a suggestion and not as a serious issue, if needed any help with the type hints part then i can help you with that part.

Querela commented 1 month ago

As far as I'm concerned, this library has type hints. But everything can be improved, so if you have good suggestions, I can review them ...

Please also check your changes with mypy. In the setup.cfg all the dev tools are defined for typing, styling/formatting, building etc. You will also notice that I'm intentionally excluding the vendor library ply since it's just a copy and future updates will simply replace the source files. So, any type hinting there is a bit wasted should better be contributed to the project itself.