Querijn / BottyMcBotface

The Riot Games API Bot
39 stars 29 forks source link

Update guru command log channel #292

Closed Token07 closed 1 year ago

Querijn commented 1 year ago

Something got lost in translation here I think

What I meant fundamentally is that the variable is used to indicate the moderators channel. Changing the value to a non-moderators channel means that anything referencing has to correctly be changed to indicate that this value is in fact nor a moderators channel.

This PR has the issue that this.adminChannel now no longer refers to an admin channel, but the location where content changes appear. Admin.channel also wouldn't refer to the admin channel anymore, but rather the content-alerts channel.

This could prove to be an brain-scratcher for future PR creators

I recommend either:

  1. Changing all references to Admin.channel or Admin.adminChannel to logChannel and adminLogChannel respectively
  2. Keeping the reference to the guruChannel the same and adding a variable for the log channel./