search

Querijn / BottyMcBotface

The Riot Games API Bot
39 stars 29 forks source link

Some users dont get noticed by commands #95

Closed stelar7 closed 5 years ago

stelar7 commented 6 years ago

i.e @instig#8737

stelar7 commented 6 years ago

Seems to be fixed by 864843febdd52daff0695e11d355c0de06069bc8, but we should check the entire codebase and replace .members with .users if thats the reason.

molenzwiebel commented 6 years ago

This is just because Discord.js doesn't guarantee that your local copy of members is 100% accurate by default. My experience with Orianna (which uses eris, but acts similar) is that on average you miss 10-20 members per server. People can get unlucky and not be loaded. You could consider using Guild.fetchMembers but it might slow you down ;).

Querijn commented 6 years ago

Hmm, might be a good idea to get that replaced with a fetch function then indeed. The slowdown should not be an issue for this case, this is a call that happens a couple of times per day at most.