Querz / mcaselector

A tool to select chunks from Minecraft worlds for deletion or export.
MIT License
3.18k stars 177 forks source link

Chunk deletion always freezes when using command line with a `.csv` (includes test case for reproduction, and stack traces) #358

Closed lordofpipes closed 2 years ago

lordofpipes commented 2 years ago

Describe the bug

When running MCAselector from the GUI and importing this .csv file for chunk deletion, it always works fine.

When doing the exact same thing using the command line, it freezes up, at a semi-random point.

To Reproduce

Steps to reproduce the behavior:

  1. Clone my minimal test case repository: https://github.com/lordofpipes/mcaselector-bug-test-case
  2. Run java -jar mcaselector-2.0.1.jar --mode delete --world ./world --selection test.csv
  3. It will not get past 60%

Screenshots and other files

Minimal test case, stripped down to a 136 MiB world that causes the problem: https://github.com/lordofpipes/mcaselector-bug-test-case

Chunk list CSV file: https://github.com/lordofpipes/mcaselector-bug-test-case/blob/master/test.csv

Here are stack traces for when it's frozen: traces.txt

^ This seems like it could implicate app//net.querz.mcaselector.io.DynamicPriorityBlockingQueue.take(DynamicPriorityBlockingQueue.java:85)

Environment:

Additional context

lordofpipes commented 2 years ago

Fixed in c9661dc6e4840ce603796b39276f55f6217ab9a2 and 2.0.2, thank you @Querz!