Querz / mcaselector

A tool to select chunks from Minecraft worlds for deletion or export.
MIT License
3.21k stars 175 forks source link

Deleting entire regions when only chunks were selected #447

Open Gayowulf opened 11 months ago

Gayowulf commented 11 months ago

Describe the bug When attempting to delete chunks, MCA Selector deletes all regions that contain any of the selected chunks, rather than just the chunks that were selected

To Reproduce

  1. Open a world in MCA Selector
  2. Select a small area of chunks (for example, a rectangular area from chunk -5, -2 to chunk 1, 3 inclusive)
  3. Press CTRL-D or go to Selection > Delete Selected Chunks
  4. Observe that the "Delete chunks" confirmation dialog shows the correct number of chunks that were selected (in the above example, "You are about to delete 42 chunks from this world."
  5. Press OK to confirm deletion
  6. Observe that all chunks in the four regions covered by this area have been deleted, for a total of 4096 chunks
  7. Open the world in Minecraft to observe that the entire regions have been deleted and must be regenerated by the game

Screenshots of the above: Screenshot_2023-10-21_001 Screenshot_2023-10-21_002 Screenshot_2023-10-21_003 Screenshot_2023-10-21_004

Expected behavior MCA Selector would only delete the chunks that were actually selected for deletion

Screenshots and other files See above screenshots.

I was not able to obtain a debug file. I enabled the option in settings, restarted MCA selector, and reproduced the problem, but could not find a "debug.log" file. Where is this file supposed to appear? It did not appear in any of the following places:

The following was printed to stdout:

WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance.

(java:300861): Gtk-WARNING **: 16:11:02.626: Theme parsing error: gtk.css:1649:16: '-gtk-icon-size' is not a valid property name

(java:300861): Gtk-WARNING **: 16:11:02.626: Theme parsing error: gtk.css:1652:16: '-gtk-icon-size' is not a valid property name

(java:300861): Gdk-WARNING **: 16:11:02.918: XSetErrorHandler() called with a GDK error trap pushed. Don't do that.

Environment:

Additional context