search

QuesmaOrg / quesma

Programmable database gateway
https://quesma.com
Other
108 stars 6 forks source link

Fix `SchemaToColumns` for `geo_point` types, add ingest integration tests #1019

Closed avelanarius closed 1 day ago

avelanarius commented 2 days ago

When a geo_point field is added to fieldEncodings, actually two fields get added:

SchemaToColumns however tried to find my_field in fieldEncodings (which was missing; only my_field.lat and my_field.lon were there). This resulted in creating (incorrect, unused) columns lat, lon since internalPropertyName was empty.

Fix the problem by accessing my_field.lat and my_field.lon keys in fieldEncodings instead (which should be there).

Add new integration test that checks Quesma's ingest of Kibana sample flights, Kibana sample ecommerce. The tests without "PUT mapping" caught the fixed issue (this is how I found it).

avelanarius commented 1 day ago

Integration tests passed: https://github.com/QuesmaOrg/quesma/actions/runs/11937331599