QuestCraftPlusPlus / PojavLauncher

A Minecraft: Java Edition Launcher for Android based on Boardwalk. Fork built specifically to run on the Meta Quest platform.
GNU General Public License v3.0
52 stars 34 forks source link

[BUG] You can't close it by oculus button #27

Open mikareq opened 2 years ago

mikareq commented 2 years ago

Describe the bug

If you are trying to quit using oculus button, the app is still working at the background.

The log file and images/videos

*

Steps To Reproduce

1. Open minecraft.
2. Open oculus menu by pressing oculus button on the right controller.
3. Exit the app.

Expected Behavior

I expect the app to close.

Platform

- Device model: Oculus quest 2

Anything else?

No response

JD-The-65th commented 2 years ago

This is technically an oculus issue since you can reproduce this in any game, not just QuestCraft. Beat Saber, Echo VR, you name it.

wellsilver commented 2 years ago

This is technically an oculus issue since you can reproduce this in any game, not just QuestCraft. Beat Saber, Echo VR, you name it.

no

if you are trying to quit by oculus button...

yesn't this is being added but isnt very high, to get around you can just click "quit" in minecraft

JD-The-65th commented 2 years ago

This is technically an oculus issue since you can reproduce this in any game, not just QuestCraft. Beat Saber, Echo VR, you name it.

no

Please elaborate further, this is an easily reproducible issue by simply quiting and reopening any VR game. In some cases, when the app opens again, it may open to a different scene, but in all the apps I've tested, it doesn't start over as a fresh open.

wellsilver commented 2 years ago

JD

this isnt an oculus issue because it working on all games but not this makes it their issue and not oculus's issue

its something you either need a good explanation to explain or understand immediately

YPetremann commented 2 years ago

I'm the kind that test if mods works, I'm often in a situation where I softlock Minecraft, it's "working" but for some reason I can't go back to minecraft pause menu (generally because an interface is locked after I had to type something), so If I quit with the oculus button, I know there will be an instance in the background, my only solution is to reboot the headset.

As questcraft go through the pojav launcher, and minecraft is not directly a quest app, I suspect that quiting via quest button force kill pojav launcher and return to oculus launcher, but minecraft is not efficiently killed.

I have some similar situation on desktop app where I've made a process that start a childprocess and if a kill signal is send I needed to handle it or the subprocess would still run.

I don't know if Oculus send some sort of signal to the app when killing, if so please make it kill minecraft, else it could be interesting that pojav launcher handle the minecraft process via some buttons like "force kill" and even "return to minecraft" by using the fact that minecraft is running in backround to return to it.

wellsilver commented 2 years ago

I'm the kind that test if mods works, I'm often in a situation where I softlock Minecraft, it's "working" but for some reason I can't go back to minecraft pause menu (generally because an interface is locked after I had to type something), so If I quit with the oculus button, I know there will be an instance in the background, my only solution is to reboot the headset.

As questcraft go through the pojav launcher, and minecraft is not directly a quest app, I suspect that quiting via quest button force kill pojav launcher and return to oculus launcher, but minecraft is not efficiently killed.

I have some similar situation on desktop app where I've made a process that start a childprocess and if a kill signal is send I needed to handle it or the subprocess would still run.

I don't know if Oculus send some sort of signal to the app when killing, if so please make it kill minecraft, else it could be interesting that pojav launcher handle the minecraft process via some buttons like "force kill" and even "return to minecraft" by using the fact that minecraft is running in backround to return to it.

its coming, nobody knows when, but its coming