search

QuestCraftPlusPlus / QuestCraft

QuestCraft - A port of Minecraft: Java Edition to the Meta Quest Platform. With the power of Pojlib.
https://discord.gg/questcraft
706 stars 199 forks source link

[BUG] Launching without microphone permission prevents login #592

Closed RedNicStone closed 4 months ago

RedNicStone commented 4 months ago

🤔 Current Behavior

When launching the application without previously granting the permission for microphone access, the app dosent proceed to the screen where the user is promoted to login using his microsoft account.

✅ Expected Behavior

The application should be usable without granting the microphone permission.

🥽 Headset Details

Device: Quest 3 QuestCraft version: v5.0.0 Installer: ADB 1.0.41 for 34.0.4-android-tools

ℹ️ Anything else?

I don't see why this permission is a requirement for this app. I believe this permission should be disabled or at least made option, especially when considering this is a closed source application.

thewiilover commented 4 months ago

@RedNicStone all requested permissions are required. if you don't want voice chat on then you can disable it from within the game using simple voice chat settings menu. again microphone access is required but it is only used for the voice chat functions of questcraft.

RedNicStone commented 4 months ago

In that case, why does this prevent sign-in on startup? A correct way to handle is the prevent the user from using voice chat in game in case microphone access is not granted, rather than to prevent use of the app without it.

thewiilover commented 4 months ago

🤔 Current Behavior

When launching the application without previously granting the permission for microphone access, the app dosent proceed to the screen where the user is promoted to login using his microsoft account.

✅ Expected Behavior

The application should be usable without granting the microphone permission.

🥽 Headset Details

Device: Quest 3 QuestCraft version: v5.0.0 Installer: ADB 1.0.41 for 34.0.4-android-tools

ℹ️ Anything else?

I don't see why this permission is a requirement for this app. I believe this permission should be disabled or at least made option, especially when considering this is a closed source application.

also wtf you mean this is a closed source app. have you even tried to look at the github profile. the source code for questcraft is located in the repo "QuestCraftPlusPlus/QCXR-XR-Wrapper" and also "QuestCraftPlusPlus/Pojlib"

TheReal-Flo commented 4 months ago

Also came just here to state the closed source thing. QuestCraft was literally open source and transparent with everything from the very beginning

TheReal-Flo commented 4 months ago

In that case, why does this prevent sign-in on startup? A correct way to handle is the prevent the user from using voice chat in game in case microphone access is not granted, rather than to prevent use of the app without it.

The game would crash, when it doesn't have the microphone permission, but when we are just talking about it, wouldn't it be possible to just not install Simple Voice Chat when the microphone permission isn't present?

thewiilover commented 4 months ago

In that case, why does this prevent sign-in on startup? A correct way to handle is the prevent the user from using voice chat in game in case microphone access is not granted, rather than to prevent use of the app without it.

this probably is possible but would require some kind of rewrite of a large chuck of questcraft's source. so it probably will never happen

Also came just here to state the closed source thing. QuestCraft was literally open source and transparent with everything from the very beginning

technically this isnt true. the wrapper was closed source in the beginning.

RedNicStone commented 4 months ago

also wtf you mean this is a closed source app. have you even tried to look at the github profile. the source code for questcraft is located in the repo "QuestCraftPlusPlus/QCXR-XR-Wrapper" and also "QuestCraftPlusPlus/Pojlib"

This is not made clear in the repo. There is no link, nor any statement that the app is open source. And when looking at this repository all I see is an empty repo what contains no source code, with no mention of that in the readme.

5ghzx commented 4 months ago

is this like the stupid smelly nerds thing?

TheReal-Flo commented 4 months ago

is this like the stupid smelly nerds thing?

Yes

RedNicStone commented 4 months ago

Also the source code has not been updated to the newest version

5ghzx commented 4 months ago

also wtf you mean this is a closed source app. have you even tried to look at the github profile. the source code for questcraft is located in the repo "QuestCraftPlusPlus/QCXR-XR-Wrapper" and also "QuestCraftPlusPlus/Pojlib"

This is not made clear in the repo. There is no link, nor any statement that the app is open source. And when looking at this repository all I see is an empty repo what contains no source code, with no mention of that in the readme.

its on github

thewiilover commented 4 months ago

Quote reply

im sorry but have you looked at the discord. there is a direct link the the repo for the wrapper in the faq channel.

TheReal-Flo commented 4 months ago

also wtf you mean this is a closed source app. have you even tried to look at the github profile. the source code for questcraft is located in the repo "QuestCraftPlusPlus/QCXR-XR-Wrapper" and also "QuestCraftPlusPlus/Pojlib"

This is not made clear in the repo. There is no link, nor any statement that the app is open source. And when looking at this repository all I see is an empty repo what contains no source code, with no mention of that in the readme.

Ermm, there actually is

The QCXR forks we use are: Pojlib, VivecraftMod, VulkanMod, and Unity Env.

thewiilover commented 4 months ago

Also the source code has not been updated to the newest version

brother, what? how do you think the devs build app

RedNicStone commented 4 months ago

also wtf you mean this is a closed source app. have you even tried to look at the github profile. the source code for questcraft is located in the repo "QuestCraftPlusPlus/QCXR-XR-Wrapper" and also "QuestCraftPlusPlus/Pojlib"

This is not made clear in the repo. There is no link, nor any statement that the app is open source. And when looking at this repository all I see is an empty repo what contains no source code, with no mention of that in the readme.

Ermm, there actually is

The QCXR forks we use are: Pojlib, VivecraftMod, VulkanMod, and Unity Env.

That is not a link the the source code

TheReal-Flo commented 4 months ago

Also the source code has not been updated to the newest version

wtf It's updated, was even updated always before the update

TheReal-Flo commented 4 months ago

That is not a link the the source code

Yes it is? Unity-Env is the Wrapper, Pojlib is the launcher library?

RedNicStone commented 4 months ago

Quote reply

im sorry but have you looked at the discord. there is a direct link the the repo for the wrapper in the faq channel.

I have not joined the discord, and this should not be required to get essential information.

Not that it matters, this isent the issue here and clearly off-topic

RedNicStone commented 4 months ago

That is not a link the the source code

Yes it is? Unity-Env is the Wrapper, Pojlib is the launcher library?

I think you do not understand the definition of source code. These are external utilities and libraries

5ghzx commented 4 months ago

no, that is the code for questcraft. that is quest craft.

5ghzx commented 4 months ago

this repo is nothing

5ghzx commented 4 months ago

just an issue hub

TheReal-Flo commented 4 months ago

That is not a link the the source code

Yes it is? Unity-Env is the Wrapper, Pojlib is the launcher library?

I think you do not understand the definition of source code. These are external utilities and libraries

What do you think QuestCraft is, it's just a Wrapper to launch Minecraft. The Main Repos are the Unity-Env and Pojlib ones

RedNicStone commented 4 months ago

no, that is the code for questcraft. that is quest craft.

None of these would enable me to build the application. Ergo: not source code of this application

thewiilover commented 4 months ago

no, that is the code for questcraft. that is quest craft.

None of these would enable me to build the application. Ergo: not soure

the wrapper allows you to build an apk file that is in fact questcraft. i would call something like that the source code

TheReal-Flo commented 4 months ago

no, that is the code for questcraft. that is quest craft.

None of these would enable me to build the application. Ergo: not source code of this application

Bet? I'm not a developer of this app and still have a self build which hashes doesn't match with any of those who got released publicly

RedNicStone commented 4 months ago

How exactly does this relate to the issue at hand?

TheReal-Flo commented 4 months ago

How exactly does this relate to the issue at hand?

I don't know, you opened an issue and stated that it's closed source, and we tried to correct you

thewiilover commented 4 months ago

How exactly does this relate to the issue at hand?

its showing that your being stubborn. please do your research before you go around calling something open source, closed source. its all avalable on this very github profile that this issue is on

RedNicStone commented 4 months ago

And I pointed out that this isent made clear in this repository, maybe this should be addressed in another issue.

RedNicStone commented 4 months ago

is this like the stupid smelly nerds thing?

Also insulting someone for opening what seems to be a fixable issue is extremely unprofessional behaviour even for a community project. I think your project may have a management/moderation problem.

I will be unsubscribing from this issue until a willingness is shown to resolve this issue.

5ghzx commented 4 months ago

they have addressed the issue, please read. It would be difficult.

thewiilover commented 4 months ago

is this like the stupid smelly nerds thing?

Also insulting someone for opening what seems to be a fixable issue is extremely unprofessional behaviour even for a community project. I think your project may have a management/moderation problem.

I will be unsubscribing from this issue until a willingness is shown to resolve this issue.

i think you should stop typing before you get yourself into more trouble than you want right now

5ghzx commented 4 months ago

is this like the stupid smelly nerds thing?

Also insulting someone for opening what seems to be a fixable issue is extremely unprofessional behaviour even for a community project. I think your project may have a management/moderation problem.

I will be unsubscribing from this issue until a willingness is shown to resolve this issue.

that wasnt an insult, that a reference to a reddit post where developers were slandered for not posting exes on their github repos.

thejudge156 commented 4 months ago

Howdy, actual developer here. I see the concern, it's a leftover piece from when we had Simple Voice Chat (SVC) installed by default. I will work on a fix now.

thejudge156 commented 4 months ago

And for future reference, Pojlib builds an AAR which goes into the wrapper. Assets/Plugins/Android is the path relative to the root of the QCXR-XR-Wrapper project. We do have some documentation in the works so stay tuned.

RedNicStone commented 4 months ago

I should probably ask this in a separate issue (or on discord), but are there any build instructions?

thejudge156 commented 4 months ago

We do have some documentation in the works so stay tuned.

^

RedNicStone commented 4 months ago

Github dosent update comments without reloading the tab for me :/

TheReal-Flo commented 4 months ago

I should probably ask this in a separate issue (or on discord), but are there any build instructions?

@RedNicStone if you want to join the Discord, you could mention me there \@TheRealFlo and I could gladly help you with the build ^^

CADIndie commented 4 months ago

I should probably ask this in a separate issue (or on discord), but are there any build instructions?

@RedNicStone if you want to join the Discord, you could mention me there @TheRealFlo and I could gladly help you with the build ^^

Hello, Lead Project Manager here, I have written documentation at https://docs.questcraft.org/getting-started/setup/, please use this (though slightly out of date) and ping me in the QuestCraft Discord, we would be glad to help directly.