Questie / Questie

Questie: The WoW Classic quest helper
989 stars 297 forks source link

Quests objectives only partly shown #1071

Closed BreakBB closed 4 years ago

BreakBB commented 5 years ago

Bug description

Reported on Discord.

On a Non-English client only some of the objectives are shown on the map. Restart and latest version didn't help.

An example is the quest Unfinished Business. Only Cavalier Durgen is showing on the map.

The objective in the screenshot below says: "Huntman Regan slain", but it is shown on the location of Cavalier Durgen which has already been slain.

Moreover if the spawnDB gets changed from {{11613,nil},{11611,nil},},nil,nil,nil,} to {{11611,nil},{11613,nil},},nil,nil,nil,}

only "Huntsman Radley" is shown!

Tracker has the same issue.

Most likely related to #819

Screenshots

WoWScrnShot_092019_160032

Questie version

4.1.1

BreakBB commented 5 years ago

This is fixed with the latest commits on the master branch and will be included in the upcoming release of 4.1.2! Thanks for your patient on this.

BreakBB commented 5 years ago

To explain this a bit more:

Our fallback logic for missing translations had a problem and therefore we didn't match the objective data correctly for each mob. So every quest which had more than 1 objective showed all objectives of the first mob listed in our database. This broke the tooltips on the mob itself and the drawing of the objective icons on the map as well.

BreakBB commented 5 years ago

This is fixed with the release of v4.1.2 https://github.com/AeroScripts/QuestieDev/releases/tag/v4.1.2

Please try that version and let us know if there still is an issue

Eveigh commented 5 years ago

the issue is still there. for example https://classic.wowhead.com/quest=49/sweet-amber have only one point on map insteed of tree image 4.1.1 with fix from #1099 work better. In 4.1.2 this fix does not work.

BreakBB commented 5 years ago

@Eveigh I am sorry to hear the fix isn't working for you as expected. The problem of the "fix" that is suggested in #1099 is that it relies on the order of objectives from the DB. If we do this we'll break other things, so we have to find another solution

Eveigh commented 5 years ago

Yes. I noticed this fix not workig in all cases. So i watching this issue. Can i privide some additional information to help?

BreakBB commented 5 years ago

@Eveigh Since I can't reproduce this issue: Could you try to edit line 880 in QuestieQuest.lua from if Quest.Objectives[objectiveIndex] == nil then to if true then and report if this helps?

Eveigh commented 5 years ago

no this is not work for me

Eveigh commented 5 years ago

@BreakBB I tested out case with kiling mobs and it works in 4.1.2 as needed even without that modification. So problem is for loot something only.

BreakBB commented 5 years ago

Fixed with 7eb8fc8b8468634cf58aa85683be4f676aed6752

We forgot to include the newly added item translations for most languages and therefore the tooltips and icons weren't working. Keep an eye out for the upcoming release!

BreakBB commented 5 years ago

v4.2.0 is out https://github.com/AeroScripts/QuestieDev/releases/tag/v4.2.0

BreakBB commented 5 years ago

With the latest reports it seems this issue still exists and now affects English clients as well.

We're currently rewriting our code to determine the objectives of a quest and how we match the finding on our data. You can expect a fix on this with the next release.

maxtest404 commented 5 years ago

In v4.3.0 this issue fix or not ?

Muehe commented 5 years ago

@maxtest404 Yes, objectives should be working fine now in all languages that have the data. Please let us know if you notice anything broken.

MaxWayborn commented 5 years ago

Version: 4.3.0 0 37acad5 Quest: More Wastewander Justice Link: https://classic.wowhead.com/quest=1691 Russian version WoW Questie - 1

MaxWayborn commented 5 years ago

Version: 4.3.0 0 37acad5 Quest: The Bloodsail Buccaneers Link: https://classic.wowhead.com/quest=608 Russian version WoW Questie - 2

Eveigh commented 5 years ago

"/reload ui" helps for me with same problem

MaxWayborn commented 5 years ago

/reload ui

It seems to work. Thanks.

Eveigh commented 5 years ago

quest All Along the Watchtowers https://classic.wowhead.com/quest=5097 image

i checked DB and spawns 10902-10905 have different point. so i think it is related to this issue. reload ui not helps Version: 5.0.1 2 e2e80b7

Eveigh commented 5 years ago

I believe that this is because of the goal of “marking” rather than “killing”

AeroScripts commented 4 years ago

The data should continue to improve over time but its a tough situation, any error in NPC names can cause this. Closing this for now