QuestingPet / ToaMistakeTracker

Tracks mistakes made by players throughout the Tombs of Amascut
BSD 2-Clause "Simplified" License
1 stars 3 forks source link

Configurable mistake messages #4

Closed Septem151 closed 1 year ago

Septem151 commented 1 year ago

PR Description

This PR adds the ability to configure messages that display overhead and in the chat box for each mistake being tracked.

Features

Small Changes

Screenshots

image

QuestingPet commented 1 year ago

Neat! I never prioritized this because I didn’t find it necessary nor did I know of anyone that wanted it. Judging by the fact that you went ahead and did it, it sounds like maybe you or some of your friends would like to customize this. Seems fair

Quick skim seems fine, though I’d prefer if you could keep the same code formatting (4 spaces for tabs) and bump the plug-in version. Will look more in depth sometime this week.

Also thanks for contributing! Hopefully the codebase wasn’t too hard to follow, though you probably had an easier time since it’s abstracted out and you didn’t have to mess with the detection logic itself :p