QuestingPet / ToaMistakeTracker

Tracks mistakes made by players throughout the Tombs of Amascut
BSD 2-Clause "Simplified" License
1 stars 3 forks source link

Can we get options to count missed prayers at zebak and akkha as mistakes? #7

Open sneeeezers opened 1 year ago

QuestingPet commented 1 year ago

Hey, thanks for the suggestion!

I'm unsure how I feel about auto-attack off-prayer mistakes. Mainly because it acts as a way to tell players that they should change something about their current play in order to prevent an upcoming thing. Most mistakes don't work like that -- most of them you're already fully punished for the mistake you make, and it doesn't necessarily allow you to use it as a mechanism for how to beat the raid in the immediate-term. For this, after seeing you made this mistake, it's an indicator to usually immediately go and change your prayer.

That being said, some mistakes obviously break this philosophy already, specifically just Akkha and Zebak overhead mistakes on the P3 Warden fight (similar to your ask). My rationale for why I allowed that is documented in the WardensP3Detector class (copied below):

 * Also lastly added, overhead tracker for Akkha and Zebak to give a mistake if a prayer is missed. Since this isn't
 * the crux of the fight, and the punish has already happened (unless you tanked), then this is not considered cheaty.
 * Since the overhead detection on the server happens the same tick that the projectile, we calculate the mistake
 * right away but delay it for the remaining cycles of the projectile. Also, I ended up deciding to just not announce
 * this mistake at all anyway, and only put it in the tracker panel, so that it can't be used to know to switch prayers
 * as easily.

I think I'd prefer to still not to add this for their actual standalone fights, as that's part of the core mechanic is knowing when to switch, and I don't necessarily want this to be seen as cheat-y. One thing we could do is similarly not announce the mistake, or even not announce the mistake nor show it in the panel until the full fight is over.

For now, I'm going to mark this as not planned, unless you and/or others feel strongly against that decision.

sneeezers commented 1 year ago

I mostly wanted it as a feature to just track improvement over time (that would also be a cool feature btw. Some sort of graph of mistakes over time). It shouldn't have an overhead text for a mistake, just as it doesn't for lightning, so I don't think it would realistically be used to tell a player when to change prayer, tanking a hit and taking big damage is enough of an incentive I think!