search

Quetzi / Morpheus

23 stars 16 forks source link

[1.14.4] Sleeping does nothing, no voting. #61

Closed ProsperCraft closed 5 years ago

ProsperCraft commented 5 years ago

https://gyazo.com/29f699b585171155799ee33a275a0d23

Morpheus-1.14.3-4.1.20

forge-1.14.3-27.0.25

Modpack - https://www.curseforge.com/minecraft/modpacks/the-adventures-of-halk

AliveDevil commented 5 years ago

Same here. Log:

Jul 13 18:42:25 minecraft java[1025]: [18:42:25.670] [Server thread/INFO] [morpheus/]: AliveDevil null 1/2 - 0 miners (50%)
Jul 13 18:42:26 minecraft java[1025]: [18:42:26.170] [Server thread/INFO] [morpheus/]: AliveDevil null 1/2 - 0 miners (50%)

Config is the default generated one with 50%. Both players need to be in bed to trigger sleep.

olee commented 5 years ago

Same here - definitely broken for 1.14.3

Quetzi commented 5 years ago

I've just uploaded a new version (4.1.22) which will hopefully solve this. I'll close this, but if it hasn't fixed it feel free to reopen the issue and I'll look at it again.

ProsperCraft commented 5 years ago

Morpheus-1.14.3-4.1.22 does not fix the problem, please reopen.

ProsperCraft commented 5 years ago

Still does not work wtih Morpheus-1.14.4-4.1.23

2019-07-28_15 55 23

ProsperCraft commented 5 years ago

Still broken with Morpheus-1.14.4-4.2.24.jar

ProsperCraft commented 5 years ago

The percentage command doesn't accept a number after it anymore.

tylerwight commented 5 years ago

Can confirm I am seeing this issue also. I have tried with Morpheus 1.14.4-4.2.24 and version 1.14.4-4.1.23

Minecraft 1.14.4 Forge 28.0.45

> /morpheus percent 20
[16:15:16.875] [Server thread/INFO] [minecraft/DedicatedServer]: Incorrect argument for command
[16:15:16.889] [Server thread/INFO] [minecraft/DedicatedServer]: ...s percent 20<--[HERE]

can't change percent with command and whenever anyone sleeps it shows this and does nothing:

 [morpheus/]: <username> null 1/2 - 0 miners (50%)
Revvilo commented 5 years ago

The percent command is written /morpheus 20 for 20%, so technically it works but just isn't programmed into the autocomplete properly. It still does nothing towards it actually working, though.

Quetzi commented 5 years ago

Just uploaded a new version that may fix some of these issues.

ProsperCraft commented 5 years ago

Try again the percentage command is missing, and sleeping does this -

unknown (1)

Quetzi commented 5 years ago

Whoops, hopefully 4.2.28 fixes more than it breaks :)

Yamza commented 5 years ago

Notifications are working correctly, but we can't adjust the percent needed as the command doesn't work.

Kaerius commented 5 years ago

As far as I understand, the mod does not create a configuration file. CSince the behavior of the mod does not change the morpheus.toml and morpheus.cfg files with the settings. Forge 28.0.55 Morpheus 4.2.28 image image

Quetzi commented 5 years ago

The config file now lives inside the world folder, I'm looking into command issues, quite a lot has changed in Forge with commands and it isn't obvious how it works. There is a new build up with some command changes 4.2.32

Quetzi commented 5 years ago

May have nailed it 4.2.33 has more command changes. This is taking a while to figure out because the machine I am doing dev on can't actually run the code in dev, so I'm hampered a bit.

Yamza commented 5 years ago

So the percent command works properly now, however the sleep vote still fails. Every person must be in bed no matter the percent it's set to.

Want to add that setting alerts to on reverts to off if the server is shut down.

Quetzi commented 5 years ago

This may now be solved with the latest build (4.2.38). Confident I've nailed this now so going to close the issue once more, will reopen if it's still an issue.