search

Quetzi / Morpheus

23 stars 16 forks source link

Ignore Spectators #62

Closed dbkynd closed 5 years ago

dbkynd commented 5 years ago

Hello, I was wondering if ignoring players that are in spectator mode might be a good addition to this mod. Thanks!

Quetzi commented 5 years ago

Hi, what is the use case for this? When would you have players in spectator mode in a survival world?

zpetty33 commented 5 years ago

On Hardcore setups, players who die are forced into spectator for the remainder of that map, until it is reset.

dbkynd commented 5 years ago

On survival servers, admins and OPS fly around in spectator mode to monitor player activity. It would be nice if they weren't counted toward the total. Also Hardcore. yeah.

Yamza commented 5 years ago

I can see the benefit in this, but it also easy enough to set the value to something appropriate knowing there may be admin/spectators on.

If you are going to do this I would suggest also having it such that anyone in creative wont count, as well as spectator.

Quetzi commented 5 years ago

From version .32 spectators and creative players are ignored

C0rn3j commented 5 years ago

@Quetzi Would you be so kind and backport this change to the 1.12.2 branch?

I realize you seem to have moved on to 1.14.x only, but since only 10%~ of the mods I use have been ported so far, I'm stuck with the 1.12 version and BetterPortals clashes quite heavily with older Morpheus, since it generates a spectator per-dimension.

If not I'll just stick with working around this by modifying SleeperPerc.

Quetzi commented 5 years ago

If I find the time I may back port it, but I wouldn't count on it. Your issue sounds like a bug report for BetterPortals.

C0rn3j commented 5 years ago

That's actually how I got here (see the reference). I'll live with the config hack then.