search

QueuQ / CGLB

Other
50 stars 15 forks source link

Find a bug. #1

Closed renyixin666 closed 2 years ago

renyixin666 commented 2 years ago

I am interested in this benchmark. When looking through the code, there seems to be a code bug in GCGL/Baselines/mas_model? https://github.com/QueuQ/CGLB/blob/966ba0e6a1ae5c0f6d0b4dd9d6f50e26200ab6f6/GCGL/Baselines/mas_model.py#L196-L197 If the moving average is calculated, it should be a multiplication operation here.

QueuQ commented 2 years ago

I am interested in this benchmark. When looking through the code, there seems to be a code bug in GCGL/Baselines/mas_model?

https://github.com/QueuQ/CGLB/blob/966ba0e6a1ae5c0f6d0b4dd9d6f50e26200ab6f6/GCGL/Baselines/mas_model.py#L196-L197

If the moving average is calculated, it should be a multiplication operation here.

Thanks a lot for pointing out this, which is really helpful! We have corrected it and updated the repository. We will also re-run the experiments and update the results later in the repository!