search

QuiCM / EssentialsPlus

Essentials and MoreAdminCommands plugins for Terraria, merged and bettered
12 stars 28 forks source link

Port to API changes on TShock 4.4.0 / Terraria 1.4.0.x #15

Closed fernandofig closed 3 years ago

tannertechnology commented 4 years ago

Hey,

Thanks for this! I was thinking about removing them but too lazy to source the following. :)

I'm testing these changes against the latest version of TShock as of writing (4.4.0pre12) and wondering if you could help update the instructions for the references to get these dependencies:

Mono.Data.SQlite.dll MySql.Data.dll Newtonsoft.Josn.dll

~Tanner

tannertechnology commented 4 years ago

To add MySql.Data.dll appears to be available as a nuget package here: https://www.nuget.org/packages/MySql.Data/

You can download the .nupkg, open with 7zip, browse through .\lib\net452\

~Tanner

Later edit:

Get mono.data.sqlite.portable, mysql.data, newtonsoft.json from NuGet manually until the solution is updated

fernandofig commented 4 years ago

I'm not sure I understand. None of those assemblies are actually dependencies, at least not for the plugin itself, so they're redundant. At least on my environment, I could build your plugin without them just fine.

Furthermore, the instructions on the README I've left on that directory where the dependencies would go are, while putting a little overhead on the developer to setup the first build, meant to avoid compatibility problems with possibly different versions of the dependencies used by the plugin vs. the ones use by TShock itself - however unlikely that may be.

Pulling those dependencies from nuget is better than bundling binary assemblies in the source, I guess, but then it's on you to make sure the references keep pointing to the same versions as the ones used by TShock... if you care about it at all, that is.

Edit: I'm sorry, I just reopened the solution and checked out the dependencies, and you're right, the SQLite and JSON.Net dependencies are required. I was working on other plugins back when I messed with yours, and did something similar to the Readme thing on them, so I probably copied the file and forgot to get the dependencies right.