search

QuiCM / EssentialsPlus

Essentials and MoreAdminCommands plugins for Terraria, merged and bettered
12 stars 28 forks source link

More command not filling up item to max stack #21

Closed CKylinMC closed 3 years ago

CKylinMC commented 3 years ago

When I using "/more", It only doubles the count of items in my hand, which is not like the descriptions said: "Maximizes item stack of held item."

https://github.com/QuiCM/EssentialsPlus/blob/dd7352526df2a2fa4a44048b41ab9c76203e9ab8/EssentialsPlus/Commands.cs#L436

I think it may should be like this:

e.Player.GiveItem(item.type, amtToAdd); // not item.stack

and L421 should be same: https://github.com/QuiCM/EssentialsPlus/blob/dd7352526df2a2fa4a44048b41ab9c76203e9ab8/EssentialsPlus/Commands.cs#L421

And, is there any way to clone a weapon or armor item?

QuiCM commented 3 years ago

Thanks. This should be fixed in the commit above. https://github.com/QuiCM/EssentialsPlus/suites/3985501375/artifacts/100317560 contains a built version of the plugin with this fix

CKylinMC commented 3 years ago

Thanks!

msva commented 2 years ago

@QuiCM can you create a new release with this fix, please?

tannertechnology commented 2 years ago

@msva You can grab a recent build from github actions now. https://github.com/QuiCM/EssentialsPlus/suites/6994455713/artifacts/274088160