search

Quick-Turn-Studio / CLionSupportForQt

19 stars 0 forks source link

False positive syntax error #34

Closed skyronic closed 3 years ago

skyronic commented 3 years ago

Some QML code I have isn't being highlighted properly. Here it is in CLion:

image

And the same in Qt Creator:

image

grabusr commented 3 years ago

Hi Anirudh

Could you paste file content with this code as text? I will be easier to reproduce this for use.

skyronic commented 3 years ago

Hi @grabusr here is the entire file:

https://github.com/pia-foss/desktop/blob/master/client/res/components/settings/pages/DedicatedIpList.qml

Our repository has a decent amount of QML with slightly more advanced (but valid) use cases. Feel free to check other files if there are syntax issues. Here are some other minor issues I noticed with the CLion Plugin (which are all valid code + work fine in Qt Creator)

image

https://github.com/pia-foss/desktop/blob/master/client/res/components/settings/pages/DedicatedIpPage.qml#L65

image

https://github.com/pia-foss/desktop/blob/master/client/res/components/common/GenericButtonArea.qml#L58

image

https://github.com/pia-foss/desktop/blob/master/client/res/components/common/OneLinkMessage.qml#L49

image

https://github.com/pia-foss/desktop/blob/master/client/res/components/common/OutlineFocusCue.qml#L29

image

https://github.com/pia-foss/desktop/blob/master/client/res/components/common/OverlayDialog.qml#L84

skyronic commented 3 years ago

Hi @grabusr

Do you have any estimate if/when some of these might be fixed? I'd be happy to test out a preview build if one is available!

grabusr commented 3 years ago

Hi Anirudh

We are so sorry about the late response. Currently we are overwhelmed by tasks. This week we have started to introduce new person that will support us in solving issues and extending our plugins.

skyronic commented 3 years ago

@grabusr No problem! Looking forward to see the updates!

jgirardet commented 3 years ago

I have same issue. it looks like it appears with strings. Screenshot_20210225_212051 Screenshot_20210225_212232 commenting fix the error

grabusr commented 3 years ago

Hi Anirudh and jgirardet

We were managed to fix some of the issues that appear in code snippets that you share with us. We need to wait two businnes dats to complete JetBrains Marketplace review. For the rest of the syntax issues we will create separate issues to keep issue tracker clean. It will help us to avoid duplication of bug reports.

skyronic commented 3 years ago

Thank you @grabusr ! Look forward to trying the fixed version!

skyronic commented 3 years ago

Hey @grabusr great work, most of the syntax issues are fixed! Some minor ones but I'll open separate issues for that. I'm going to close this since most pressing issues are fixed!

Happy to be a paying user! Looking forward to seeing more updates on this!