Quick / Nimble

A Matcher Framework for Swift and Objective-C
https://quick.github.io/Nimble/documentation/nimble/
Apache License 2.0
4.8k stars 601 forks source link

Rename AsyncDefaults to PollingDefaults #1023

Closed younata closed 1 year ago

younata commented 1 year ago

Forgot about this until I was writing the documentation about configuring AsyncDefaults.

Given the overall rename of the toEventually and waitUntil version of async to the more accurate "polling", it makes logical sense to rename the AsyncDefaults closure to PollingDefaults.

This is implemented to be just a deprecation warning with a replaced. The functionality is still the same. My idea is to keep the AsyncDefaults struct around for a bit longer. After Nimble 12 is released, I'll submit a PR changing the deprecation warning to a removed. After Nimble 13, I'll fully remove AsyncDefaults.

This feels like a more-than-fair enough offramp.