search

Quick / Nimble

A Matcher Framework for Swift and Objective-C
https://quick.github.io/Nimble/documentation/nimble/
Apache License 2.0
4.8k stars 596 forks source link

Add visionOS support #1098

Closed stonko1994 closed 7 months ago

stonko1994 commented 9 months ago

This PR builds upon https://github.com/Quick/Nimble/pull/1083 but includes CocoaPods and testing support.

Before this PR can be merged, two counterparts PRs in CwlPreconditionTesting need to be merged first:

Based on this PR, I opened a discussion to outline a problematic usage of Carthage.

Checklist - While not every PR needs it, new features should consider this list:

stonko1994 commented 9 months ago

@younata I have some questions how to handle certain things in this PR:

younata commented 9 months ago

This is good work! Thank you so much for pushing for this.

  • How to handle the dependency PRs of CwlPreconditionTesting if they are not getting picked up in a timely manner?

I think what we have here, pointing to a fork, is good for now. I'm hesitant to release a version pointing to the forks, but we'll cross that bridge when we get there. Presumably CwlPreconditionTesting is also hesitant to officially support for an unreleased platform.

  • What is the strategy for the CI and the tests? Currently, it would fail since there is no Xcode 15.1 installed, and therefore, visionOS is unknown. Should we skip the visionOS tests for now and update to the according macOS images once it is included in a stable Xcode version?

I think that's the best we can do for now. We'll probably have to wait even longer for GitHub to add images that include visionOS.

stonko1994 commented 9 months ago

Thanks 🙇‍♂️ I modified the test script to skip visionOS tests if no SDK is present: b86604f

stonko1994 commented 9 months ago

@younata, I tried to fix the failing CI steps. Should be working now.

stonko1994 commented 9 months ago

The PRs in CwlPreconditionTesting were merged and I reverted back to the official repo 💪

stonko1994 commented 8 months ago

@younata I merged main into this branch to also use the transitive dependency changes 🙌

I would still wait for https://github.com/Quick/Nimble/pull/1107 to be finished before I update the build on this PR.

younata commented 7 months ago

@stonko1994 I (finally...) got around to getting #1107 working and merged. Looking forward to THAT being taken care of from now on. Please pull in current main, and I'll be happy to merge this as soon as I can.

stonko1994 commented 7 months ago

@younata I merged main into this branch 💪 Please execute the CI checks to see if everything works as expected now. Other than that it's ready to be merged from my side.