search

QuickBirdEng / XCoordinator

🎌 Powerful navigation library for iOS based on the coordinator pattern
MIT License
2.24k stars 176 forks source link

Initial Commit #177

Closed mung4i closed 2 years ago

mung4i commented 4 years ago

This pull request contains the following changes

pauljohanneskraft commented 4 years ago

Hey @mung4i - as I can see you worked on adding embed and unembed transitions to XCoordinator - I like it, thanks for your contributions! However, it feels like the implementation is not finished yet, since the animations are not used for the transitions, even though they can be specified - and the code comments claim, you could use Animation.default to get UIKit-default animations, which is not the case, since Animation does not conform to TransitionAnimation, but is rather an object to allow specifying a presentation and dismiss TransitionAnimation.

I applaud your efforts to making XCoordinator an even better framework, but I think the current implementation is not yet ready for XCoordinator - would you like to adapt the changes, possibly looking for a solution on how to add animations to embed/unembed transitions?

mung4i commented 4 years ago

I would. Thanks for the feedback, its very helpful... looking forward to the pushing the changes. I needed some guidance on how to build the project. I wasn't able to successfully build it.

pauljohanneskraft commented 2 years ago

Closing due to inactivity - I will consider building this on my own in the future.