search

QuickBlox / quickblox-ios-sdk

QuickBlox iOS SDK for messaging and video calling
https://quickblox.com/developers/IOS
MIT License
396 stars 358 forks source link

Getting extra space at bottom in ChatViewController while push from DialogVC #1320

Closed dhaneshgosai closed 1 year ago

dhaneshgosai commented 2 years ago

New Issue Checklist

Environment details

Info Getting extra space at the bottom in ChatViewController while pushing from DialogVC Value
iOS Version 13.0
Quickblox iOS SDK version 2.17.10
QuickbloxWebRTC SDK version 2.17.10
Xcode Version Xcode 13.2
Repro with our demo sample No it's working fine with sample demo

Did this work before? No Its not working at all

Expected behavior It should take the full height of the screen.

Actual behavior Getting extra space at bottom in Chat screen

Steps to reproduce the behavior With TabBar controller its getting extra space at the bottom

dhaneshgosai commented 2 years ago

Please check the attached screenshot for more insights on the issue:

Screenshot 2022-07-01 at 11 11 44 PM
ghost commented 2 years ago

@dhaneshgosai Hello, this is Nikolay from QuickBlox support. Please let me know if the below code is helpful: NSLayoutConstraint.activate([NSLayoutConstraint(item: inputToolbar, attribute: .bottom, relatedBy: .equal, toItem: view, attribute: .bottom, multiplier: 1.0, constant: 0.0)]) If the issue persists, please provide the following points:

  1. Am I right that the issue is reproduced on the sample? Swift or ObjC?
  2. Have you modified the sample and how?
  3. Please provide more detailed instructions on how to reproduce the issue on our end.
dhaneshgosai commented 2 years ago

Heyy Nikolay,

Thanks for the response to my issue.

Actually, I tried the above-suggested code on my app but still facing the same issue of extra blank space at bottom of my chat screen.

Answering your few questions:

  1. Am I right that the issue is reproduced on the sample? Swift or ObjC? Ans: No it's not reproducing on any of the sample apps only on my app where I integrated the QuickBlox library.
  2. Have you modified the sample and how? Ans: I haven't modified the sample code instead I integrated code in my app from your sample code.
  3. Please provide more detailed instructions on how to reproduce the issue on our end. Ans: With the TabbarController it's creating an issue Please check the below point to reproduce it.

When we use TabBar Controller and Push ChatViewController in Tabbar and hide Tabbar or ChatViewController at that time it's showing a blank space at the bottom and does not spread the collection view and toolbar item on the whole screen.

When I debug it required full view height is 844px (for iPhone11-13) but it always takes 626px only.

View Size Log: <UIView: 0x7fe5acc7fa00; frame = (0 91; 390 626); layer = <CALayer: 0x600000e4e2c0>>

Strange it should take the full screen and should not leave extra space at the bottom of the ChatVC. This issue is not occurring if I present ChatViewController only on Push on Tabbar creating a problem.

Here I am attaching a small video of the issue which I am facing.

https://user-images.githubusercontent.com/1092509/178105157-add55b72-d92f-4953-b5d5-1f103d5df408.mov

Let me know if you need any more details on this.

Hoping quick response on this as I am stuck only on this issue and cant release my chat feature on AppStore for users.

Thanks.