QuickBox / QB

QuickBox is much more than a ‘seedbox installer script’, it is a simplistic approach to achieving easy seedbox and services management from a beautifully designed dashboard. Allowing users the ability to interact with their seedbox and server on a professional grade level.
https://quickbox.io
GNU General Public License v3.0
739 stars 171 forks source link

Typo in cronjob for letsencrypt renewal #189

Open munchie45 opened 4 years ago

munchie45 commented 4 years ago

Line 37 in packages/package/install/installpackage-letsencrypt:

line="30 2 * * 1 "~/acme.sh-master"/acme.sh --cron --home "~/acme.sh" > /dev/null"

First of all why to use ~/acme.sh-master/acme.sh when it's installed in ~/.acme.sh ? Why even add this to a CRON job when acme.sh does it automatically? Second thing --home is ~/.acme.sh (DOT is missing)

Kind regards

inverse commented 4 years ago

@munchie45 why not PR this?