search

QuickLogic-Corp / qorc-sdk

Open source FreeRTOS SDK for EOS S3 MCU+eFPGA SoC including gateware, software and documentation under QuickLogic Open Reconfigurable Computing (QORC) Initiative
Apache License 2.0
44 stars 27 forks source link

BSP/qomu: fix qomu_hardwaresetup declaration #137

Open trabucayre opened 3 years ago

trabucayre commented 3 years ago

There is a inconsistency between function declaration (BSP/inc/qomu_hardwaresetup.h) and implementation (BSP/src/qomu_hardwaresetup.c). Former has an upper case 'S' and latter has an lower case 's'.

Due to this case issue a warning appear at compile time:

xxx/src/main.c: In function 'main':
xxx/src/main.c:22:2: warning: implicit declaration of function 'qomu_hardwaresetup'; did you mean 'qomu_hardwareSetup'? [-Wimplicit-function-declaration]
   22 |  qomu_hardwaresetup();
      |  ^~~~~~~~~~~~~~~~~~
      |  qomu_hardwareSetup

According to all examples name must be qomu_hardwaresetup.

Side question: quickfeather setup is called qf_hardwareSetup (uppercase 'S') why not using same naming convention for Qomu?

trabucayre commented 3 years ago

ping ? checks failure seems not related to this PR.

coolbreeze413 commented 2 years ago

@trabucayre Yes you are right, we will work on fixing this as part of adding new applications to qomu shortly.