search

QuickLogic-Corp / quicklogic-fpga-toolchain

Open Source FPGA toolchain and documentation for QuickLogic devices and eFPGA IP
https://quicklogic-quicklogic-fpga-toolchain.readthedocs-hosted.com/en/latest/index.html
Apache License 2.0
36 stars 8 forks source link

Conda installer is not reproducible #43

Closed whitequark closed 3 years ago

whitequark commented 3 years ago

The last step in the conda installer is to install a pip package from a git repository without specifying a particular revision. This means that, even if you might expect that you will be able to run sh Symbiflow_v1.3.0.gz.run in the future and get the exact same packages installed as when you ran it in the past, this is not the case.

pip install git+https://github.com/QuickLogic-Corp/quicklogic-fasm
kkumar23 commented 3 years ago

@kgugala if this is right, should we specify any particular version ?

kgugala commented 3 years ago

in 1.3 we can freeze it on current master's HEAD. Simply change the line to:

pip install git+https://github.com/QuickLogic-Corp/quicklogic-fasm@318abca
kkumar23 commented 3 years ago

@whitequark : updated with the suggestions from Karol. Now it should refer to a fixed version

whitequark commented 3 years ago

I've checked the script and I believe this issue is fixed.